linux-kernel - Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191009085751.h3voimqz25kj6lh2@pengutronix.de>
Date:   Wed, 9 Oct 2019 10:57:51 +0200
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Anson Huang <anson.huang@....com>
Cc:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Aisheng Dong <aisheng.dong@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH V2] firmware: imx: Skip return value check for some
 special SCU firmware APIs

On 19-10-09 08:28, Anson Huang wrote:
> Hi, Marco
> 
> > On 19-10-08 00:48, Anson Huang wrote:
> > > Hi, Marco
> > >
> > > > On 19-10-07 09:15, Anson Huang wrote:
> > > > > The SCU firmware does NOT always have return value stored in
> > > > > message header's function element even the API has response data,
> > > > > those special APIs are defined as void function in SCU firmware,
> > > > > so they should be treated as return success always.
> > > > >
> > > > > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > > > > ---
> > > > > Changes since V1:
> > > > > 	- Use direct API check instead of calling another function to check.
> > > > > 	- This patch is based on
> > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > > > > patc
> > > > >
> > > >
> > hwork.kernel.org%2Fpatch%2F11129553%2F&amp;data=02%7C01%7Canson.
> > > > huang%
> > > > >
> > > >
> > 40nxp.com%7C2de0a6be69b74cc249ad08d74afc9730%7C686ea1d3bc2b4c6f
> > > > a92cd99
> > > > >
> > > >
> > c5c301635%7C0%7C0%7C637060321046247040&amp;sdata=RMFAdLKGKb6
> > > > mEdhycrzHX
> > > > > R03E6Qr5pWyRc8Zk6ErlBc%3D&amp;reserved=0
> > > >
> > > > Thanks for this v2. It would be good to change the callers within this
> > series.
> > >
> > > NOT quite understand your point, the callers does NOT need to be
> > > changed, those
> > > 2 special APIs callers are already following the right way of calling the APIs.
> > 
> > Ah okay. I searched the 5.4-rc2 tag and found the soc_uid_show() as only
> > user but this user sets the have_resp field to false. Is this intended?
> 
> I already fixed it and patch applied by Shawn, see below:
> 
> https://patchwork.kernel.org/patch/11129497/

I see :) So one last question, please check the other thread.

Regards,
  Marco

> 
> Anson
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |