linux-kernel - Re: [PATCH] crypto: jitter - add header to fix buildwarnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2519389.eumGI5PgG6@tauon.chronox.de>
Date:   Wed, 09 Oct 2019 11:22:56 +0200
From:   Stephan Mueller <smueller@...onox.de>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au,
        linux-kernel@...ts.codethink.co.uk
Subject: Re: [PATCH] crypto: jitter - add header to fix buildwarnings

Am Mittwoch, 9. Oktober 2019, 11:12:56 CEST schrieb Ben Dooks:

Hi Ben,

> Fix the following build warnings by adding a header for
> the definitions shared between jitterentropy.c and
> jitterentropy-kcapi.c. Fixes the following:
> 
> crypto/jitterentropy.c:445:5: warning: symbol 'jent_read_entropy' was not
> declared. Should it be static? crypto/jitterentropy.c:475:18: warning:
> symbol 'jent_entropy_collector_alloc' was not declared. Should it be
> static? crypto/jitterentropy.c:509:6: warning: symbol
> 'jent_entropy_collector_free' was not declared. Should it be static?
> crypto/jitterentropy.c:516:5: warning: symbol 'jent_entropy_init' was not
> declared. Should it be static? crypto/jitterentropy-kcapi.c:59:6: warning:
> symbol 'jent_zalloc' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:64:6: warning: symbol 'jent_zfree' was not
> declared. Should it be static? crypto/jitterentropy-kcapi.c:69:5: warning:
> symbol 'jent_fips_enabled' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:74:6: warning: symbol 'jent_panic' was not
> declared. Should it be static? crypto/jitterentropy-kcapi.c:79:6: warning:
> symbol 'jent_memcpy' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:93:6: warning: symbol 'jent_get_nstime' was
> not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Reviewed-by: Stephan Mueller <smueller@...onox.de

Ciao
Stephan