linux-kernel - Re: [PATCH 1/3] regulator: core: fix boot-on regulators use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191009095418.GA3929@sirena.co.uk>
Date:   Wed, 9 Oct 2019 10:54:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Marco Felsch <m.felsch@...gutronix.de>
Cc:     Doug Anderson <dianders@...omium.org>,
        Chunyan Zhang <zhang.chunyan@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        ckeepax@...nsource.cirrus.com, LKML <linux-kernel@...r.kernel.org>,
        Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count
 usage

On Tue, Oct 08, 2019 at 10:16:22PM +0200, Marco Felsch wrote:
> On 19-10-08 17:23, Mark Brown wrote:

> > As you'll have seen from the discussion that's a bug, nothing should be
> > taking a reference to the regulator outside of explicit enable calls.

> Okay now we are on the right way :) Is the solution proposed by Doug:
> ".. we need to match "regulator->enable_count" to "rdev->use_count" at
> the end of _regulator_get() in the exclusive case..." the correct fix?

Yes, I think so.

> Another question. Please can you have a look on the "DA9062 PMIC fixes
> and features" series as well?

I don't know what that is, sorry.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)