linux-kernel - Re: [PATCH v10 1/6] leds: populate the device's of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Oct 2019 13:52:05 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Jean-Jacques Hiblot <jjhiblot@...com>,
        <jacek.anaszewski@...il.com>, <pavel@....cz>, <sre@...nel.org>,
        <robh+dt@...nel.org>, <mark.rutland@....com>,
        <lee.jones@...aro.org>, <daniel.thompson@...aro.org>
CC:     <dmurphy@...com>, <linux-leds@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v10 1/6] leds: populate the device's of_node

Hi JJ,

On 09/10/2019 11:51, Jean-Jacques Hiblot wrote:
> If initialization data is available and its fwnode is actually a of_node,
> store this information in the led device's structure. This will allow the
> device to use or provide OF-based API such (devm_xxx).
> 
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@...com>
> ---
>   drivers/leds/led-class.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 647b1263c579..bfa1b1033274 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -276,8 +276,10 @@ int led_classdev_register_ext(struct device *parent,
>   		mutex_unlock(&led_cdev->led_access);
>   		return PTR_ERR(led_cdev->dev);
>   	}
> -	if (init_data && init_data->fwnode)
> +	if (init_data && init_data->fwnode) {
>   		led_cdev->dev->fwnode = init_data->fwnode;
> +		led_cdev->dev->of_node = to_of_node(init_data->fwnode);
> +	}
>   
>   	if (ret)
>   		dev_warn(parent, "Led %s renamed to %s due to name collision",

This doesn't compile, as it's missing #include <linux/of.h> (which you 
add in the next patch).

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki