linux-kernel - Re: [PATCH] KVM: x86: fix bugon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d6e152d-97f4-ddcc-15ad-18b7da60c3ca@redhat.com>
Date:   Wed, 9 Oct 2019 13:07:15 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Julia Lawall <julia.lawall@...6.fr>,
        Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Radim Krčmář <rkrcmar@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] KVM: x86: fix bugon.cocci warnings

On 29/09/19 18:43, Julia Lawall wrote:
> From: kbuild test robot <lkp@...el.com>
> 
> Use BUG_ON instead of a if condition followed by BUG.
> 
> Generated by: scripts/coccinelle/misc/bugon.cocci
> 
> Fixes: 4b526de50e39 ("KVM: x86: Check kvm_rebooting in kvm_spurious_fault()")
> CC: Sean Christopherson <sean.j.christopherson@...el.com>
> Signed-off-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   02dc96ef6c25f990452c114c59d75c368a1f4c8f
> commit: 4b526de50e39b38cd828396267379183c7c21354 KVM: x86: Check kvm_rebooting in kvm_spurious_fault()
> :::::: branch date: 9 hours ago
> :::::: commit date: 4 days ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  x86.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -360,8 +360,7 @@ EXPORT_SYMBOL_GPL(kvm_set_apic_base);
>  asmlinkage __visible void kvm_spurious_fault(void)
>  {
>  	/* Fault while not rebooting.  We want the trace. */
> -	if (!kvm_rebooting)
> -		BUG();
> +	BUG_ON(!kvm_rebooting);
>  }
>  EXPORT_SYMBOL_GPL(kvm_spurious_fault);
> 

Queued, thanks!

Paolo