linux-kernel - Re: [PATCH] clk: at91: add compatible for sam9x60

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8fabb4e-81be-6219-ec5c-8d236a8959e7@microchip.com>
Date:   Wed, 9 Oct 2019 12:17:10 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <alexandre.belloni@...tlin.com>
CC:     <mturquette@...libre.com>, <sboyd@...nel.org>,
        <Nicolas.Ferre@...rochip.com>, <linux-clk@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: at91: add compatible for sam9x60

Hi,

On 08.10.2019 19:54, Alexandre Belloni wrote:
> Hi,
> 
> On 08/10/2019 19:46:26+0300, Claudiu Beznea wrote:
>> Add compatible for SAM9X60's PMC.
> 
> I think the commit log could be clearer and mention why this is needed
> and the compatible string in sam9x60 is not sufficient.

I had issues with waking up from ULP1 without even having configuring
wakeup sources.

But, investigating more I discovered that this patch breaks other things
so please ignore it.

Sorry for the noise,
Claudiu Beznea

> 
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
>> ---
>>  drivers/clk/at91/pmc.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
>> index db24539d5740..24975bca608e 100644
>> --- a/drivers/clk/at91/pmc.c
>> +++ b/drivers/clk/at91/pmc.c
>> @@ -271,6 +271,7 @@ static struct syscore_ops pmc_syscore_ops = {
>>  
>>  static const struct of_device_id sama5d2_pmc_dt_ids[] = {
> 
> Maybe rename the array?
> 
>>  	{ .compatible = "atmel,sama5d2-pmc" },
>> +	{ .compatible = "microchip,sam9x60-pmc" },
>>  	{ /* sentinel */ }
>>  };
>>  
>> -- 
>> 2.7.4
>>
>