linux-kernel - Re: [PATCH] staging: media: Fix alignment to match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Oct 2019 15:02:12 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Amol Grover <frextrite@...il.com>,
        Steve Longerbeam <slongerbeam@...il.com>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: Fix alignment to match open parenthesis

Hi Amol,

For future reference: always include the driver name in the subject.

I've added "imx: " to the subject for you, so no need to resend, but
the driver name is important information.

Regards,

	Hans

On 9/11/19 6:56 PM, Amol Grover wrote:
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Amol Grover <frextrite@...il.com>
> ---
>  drivers/staging/media/imx/imx-media-csi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 367e39f5b382..773b3d6964cf 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -627,8 +627,8 @@ static int csi_idmac_start(struct csi_priv *priv)
>  	}
>  
>  	priv->nfb4eof_irq = ipu_idmac_channel_irq(priv->ipu,
> -						 priv->idmac_ch,
> -						 IPU_IRQ_NFB4EOF);
> +						  priv->idmac_ch,
> +						  IPU_IRQ_NFB4EOF);
>  	ret = devm_request_irq(priv->dev, priv->nfb4eof_irq,
>  			       csi_idmac_nfb4eof_interrupt, 0,
>  			       "imx-smfc-nfb4eof", priv);
> @@ -1472,7 +1472,7 @@ static void csi_try_fmt(struct csi_priv *priv,
>  			imx_media_enum_mbus_format(&code, 0,
>  						   CS_SEL_ANY, false);
>  			*cc = imx_media_find_mbus_format(code,
> -							CS_SEL_ANY, false);
> +							 CS_SEL_ANY, false);
>  			sdformat->format.code = (*cc)->codes[0];
>  		}
>  
>