[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191009130818.GB4148375@kroah.com>
Date: Wed, 9 Oct 2019 15:08:18 +0200
From: Greg KH <greg@...ah.com>
To: Alexander Gordeev <a.gordeev.box@...il.com>
Cc: linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
Michael Chen <micchen@...era.com>, dmaengine@...r.kernel.org
Subject: Re: [PATCH RFC v2 2/2] dmaengine: avalon: Intel Avalon-MM DMA
Interface for PCIe test
On Wed, Oct 09, 2019 at 12:12:31PM +0200, Alexander Gordeev wrote:
> +config AVALON_TEST_TARGET_BASE
> + hex "Target device base address"
> + default "0x70000000"
> +
> +config AVALON_TEST_TARGET_SIZE
> + hex "Target device memory size"
> + default "0x10000000"
Don't put stuff like this as a configuration option, requiring the
kernel to be rebuilt. Make it dynamic, or from device tree, but not
like this.
thanks,
greg k-h
Powered by blists - more mailing lists