linux-kernel - Re: [RFC v2 0/1] s390/purgatory: Make sure we fail the build if purgatory has missing symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <ee1e9da7-2f5a-8651-78ba-15398c4ceab6@de.ibm.com>
Date:   Wed, 9 Oct 2019 16:50:22 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Philipp Rudo <prudo@...ux.ibm.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Ingo Molnar <mingo@...hat.com>
Cc:     Heiko Carstens <heiko.carstens@...ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Nathan Chancellor <natechancellor@...il.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC v2 0/1] s390/purgatory: Make sure we fail the build if
 purgatory has missing symbols

On 09.10.19 11:39, Philipp Rudo wrote:
> Hi Hans,
> 
> also adding Ingo on Cc.
> 
> I tested you patch on s390 and it does what it's supposed to do. The build now
> fails with 
> 
>   LD      arch/s390/purgatory/purgatory.chk
> arch/s390/purgatory/purgatory: In function `sha256_update':
> (.text+0x3bc2): undefined reference to `memzero_explicit'
> /home/prudo/git/linux/linux/arch/s390/purgatory/Makefile:38: recipe for target 'arch/s390/purgatory/purgatory.chk' failed
> make[3]: *** [arch/s390/purgatory/purgatory.chk] Error 1
> 
> After applying Arvid's memzero_explizit fix ("[PATCH] lib/string: make
> memzero_explicit inline instead of external") as well the build works again.
> 
> My only problem is how to uptream your patch. Just adding it to our branch
> would cause a (intentional) build breakage until Ingo's branch is merged.
> 
> @Vasliy & Ingo: Can you please find a solution for this.


I talked quickly to Vasily. The best solution is likely to carry that
patch in the tree that contains the fix. Ingo, can you carry the s390
patch in your tip tree as well?

With my s390 co-maintainer hat on:

Acked-by: Christian Borntraeger <borntraeger@...ibm.com>

Please also consider Philipps mail as "Tested-by:"