lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Oct 2019 04:01:46 +0000 From: Appana Durga Kedareswara Rao <appanad@...inx.com> To: Anssi Hannula <anssi.hannula@...wise.fi> CC: "wg@...ndegger.com" <wg@...ndegger.com>, "mkl@...gutronix.de" <mkl@...gutronix.de>, "davem@...emloft.net" <davem@...emloft.net>, Michal Simek <michals@...inx.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-can@...r.kernel.org" <linux-can@...r.kernel.org> Subject: RE: [PATCH 2/6] net: can: xilinx_can: Fix flags field initialization for axi can and canps Hi, <Snip> > On 18.3.2019 13.32, Appana Durga Kedareswara rao wrote: > > AXI CAN IP and CANPS IP supports tx fifo empty feature, this patch > > updates the flags field for the same. > > > > Signed-off-by: Appana Durga Kedareswara rao > > <appana.durga.rao@...inx.com> > > --- > > drivers/net/can/xilinx_can.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/can/xilinx_can.c > > b/drivers/net/can/xilinx_can.c index 2de51ac..22569ef 100644 > > --- a/drivers/net/can/xilinx_can.c > > +++ b/drivers/net/can/xilinx_can.c > > @@ -1428,6 +1428,7 @@ static const struct dev_pm_ops xcan_dev_pm_ops > = > > { }; > > > > static const struct xcan_devtype_data xcan_zynq_data = { > > + .flags = XCAN_FLAG_TXFEMP, > > .bittiming_const = &xcan_bittiming_const, > > .btr_ts2_shift = XCAN_BTR_TS2_SHIFT, > > .btr_sjw_shift = XCAN_BTR_SJW_SHIFT, > > Thanks for catching this, this line seemed to have been incorrectly removed by > my 9e5f1b273e ("can: xilinx_can: add support for Xilinx CAN FD core"). > > But: > > > @@ -1435,6 +1436,7 @@ static const struct xcan_devtype_data > > xcan_zynq_data = { }; > > > > static const struct xcan_devtype_data xcan_axi_data = { > > + .flags = XCAN_FLAG_TXFEMP, > > .bittiming_const = &xcan_bittiming_const, > > .btr_ts2_shift = XCAN_BTR_TS2_SHIFT, > > .btr_sjw_shift = XCAN_BTR_SJW_SHIFT, > > > Are you sure this is right? > In the documentation [1] there does not seem to be any TXFEMP interrupt, it > would be interrupt bit 14 but AXI CAN 5.0 seems to only go up to 11. > > Or maybe it is undocumented or there is a newer version somewhere? Sorry for the delay in the reply. Agree TXFEMP interrupt feature is not supported by the Soft IP CAN. Since this patch already got applied will send a separate patch to fix this. Regards, Kedar. > > [1] > https://www.xilinx.com/support/documentation/ip_documentation/can/v5_0 > /pg096-can.pdf > > -- > Anssi Hannula / Bitwise Oy > +358 503803997
Powered by blists - more mailing lists