linux-kernel - Re: [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1570635458.5937.15.camel@lca.pw>
Date:   Wed, 09 Oct 2019 11:37:38 -0400
From:   Qian Cai <cai@....pw>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>,
        linux-kernel@...ts.codethink.co.uk
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack

On Wed, 2019-10-09 at 16:11 +0100, Ben Dooks wrote:
> Include <linux/huge_mm.h> for the definition of
> is_vma_temporary_stack to fix the following
> sparse warning:
> 
> mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

It makes sense.

Reviewed-by: Qian Cai <cai@....pw>

> ---
> Cc: linux-mm@...ck.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  mm/rmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d9a23bb773bf..0c7b2a9400d4 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -61,6 +61,7 @@
>  #include <linux/mmu_notifier.h>
>  #include <linux/migrate.h>
>  #include <linux/hugetlb.h>
> +#include <linux/huge_mm.h>
>  #include <linux/backing-dev.h>
>  #include <linux/page_idle.h>
>  #include <linux/memremap.h>