linux-kernel - Re: [PATCH] drm/panfrost: Remove NULL check for regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Oct 2019 13:40:28 -0500
From:   Rob Herring <robh@...nel.org>
To:     Steven Price <steven.price@....com>
Cc:     Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/panfrost: Remove NULL check for regulator

On Fri, Oct 4, 2019 at 9:44 AM Steven Price <steven.price@....com> wrote:
>
> devm_regulator_get() is used to populate pfdev->regulator which ensures
> that this cannot be NULL (a dummy regulator will be returned if
> necessary). So remove the check in panfrost_devfreq_target().
>
> Signed-off-by: Steven Price <steven.price@....com>
> ---
> This looks like it was accidentally reintroduced by the merge from
> drm-next into drm-misc-next due to the duplication of "drm/panfrost: Add
> missing check for pfdev-regulator" (commits c90f30812a79 and
> 52282163dfa6).
> ---
>  drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Applied, thanks.

Rob