[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 10 Oct 2019 22:14:00 +0200
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Matt Helsley <mhelsley@...are.com>,
LKML <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...nel.org>, kernel@...gutronix.de,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling
On Thu, Oct 10, 2019 at 12:23:21PM -0400, Steven Rostedt wrote:
> On Wed, 9 Oct 2019 17:22:18 +0200
> Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
>
> > > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
> > > index 3796eb37fb12..6dbec46b7703 100644
> > > --- a/scripts/recordmcount.h
> > > +++ b/scripts/recordmcount.h
> > > @@ -389,11 +389,8 @@ static int nop_mcount(Elf_Shdr const *const relhdr,
> > > mcountsym = get_mcountsym(sym0, relp, str0);
> > >
> > > if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
> > > - if (make_nop) {
> > > + if (make_nop)
> > > ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
> > > - if (ret < 0)
> > > - return -1;
> > > - }
> >
> > Yes, this patch fixes building for me.
>
> May I add to my patch:
>
> Reported-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Tested-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Yeah, sure.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Powered by blists - more mailing lists