linux-kernel - Re: [PATCH] rpmsg: glink: Remove channel decouple from rpdev release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d9ebbc4.1c69fb81.b45e2.25ce@mx.google.com>
Date:   Wed, 09 Oct 2019 22:04:02 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Chris Lew <clew@...eaurora.org>, bjorn.andersson@...aro.org,
        ohad@...ery.com
Cc:     aneela@...eaurora.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chris Lew <clew@...eaurora.org>
Subject: Re: [PATCH] rpmsg: glink: Remove channel decouple from rpdev release

Quoting Chris Lew (2019-10-08 18:33:45)
> If a channel is being rapidly restarted and the kobj release worker is
> busy, there is a chance the the rpdev_release function will run after
> the channel struct itself has been released.
> 
> There should not be a need to decouple the channel from rpdev in the
> rpdev release since that should only happen from the channel close
> commands.
> 
> Signed-off-by: Chris Lew <clew@...eaurora.org>

Fixes tag? The whole thing sounds broken and probably is still racy in
the face of SMP given that channel->rpdev is tested for "published" or
not. Can you describe the race that you're closing more?