linux-kernel - Re: [PATCH v3 10/10] drivers/lkdtm: Remove references to CONFIG_REFCOUNT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201910101350.FD2B60A5A@keescook>
Date:   Thu, 10 Oct 2019 13:50:40 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Will Deacon <will@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Elena Reshetova <elena.reshetova@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Hanjun Guo <guohanjun@...wei.com>,
        Jan Glauber <jglauber@...vell.com>
Subject: Re: [PATCH v3 10/10] drivers/lkdtm: Remove references to
 CONFIG_REFCOUNT_FULL

On Mon, Oct 07, 2019 at 04:47:03PM +0100, Will Deacon wrote:
> CONFIG_REFCOUNT_FULL no longer exists, so remove all references to it.

Same thing: I think this can be collapsed into patch 8.

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> 
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Elena Reshetova <elena.reshetova@...el.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Cc: Kees Cook <keescook@...omium.org>
> Signed-off-by: Will Deacon <will@...nel.org>
> ---
>  drivers/misc/lkdtm/refcount.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/lkdtm/refcount.c b/drivers/misc/lkdtm/refcount.c
> index abf3b7c1f686..de7c5ab528d9 100644
> --- a/drivers/misc/lkdtm/refcount.c
> +++ b/drivers/misc/lkdtm/refcount.c
> @@ -119,7 +119,7 @@ void lkdtm_REFCOUNT_DEC_ZERO(void)
>  static void check_negative(refcount_t *ref, int start)
>  {
>  	/*
> -	 * CONFIG_REFCOUNT_FULL refuses to move a refcount at all on an
> +	 * refcount_t refuses to move a refcount at all on an
>  	 * over-sub, so we have to track our starting position instead of
>  	 * looking only at zero-pinning.
>  	 */
> @@ -202,7 +202,6 @@ static void check_from_zero(refcount_t *ref)
>  
>  /*
>   * A refcount_inc() from zero should pin to zero or saturate and may WARN.
> - * Only CONFIG_REFCOUNT_FULL provides this protection currently.
>   */
>  void lkdtm_REFCOUNT_INC_ZERO(void)
>  {
> -- 
> 2.23.0.581.g78d2f28ef7-goog
> 

-- 
Kees Cook