[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 10 Oct 2019 15:10:53 -0700
From: Joe Perches <joe@...ches.com>
To: Robert Richter <rrichter@...vell.com>,
Borislav Petkov <bp@...en8.de>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Tony Luck <tony.luck@...el.com>
Cc: James Morse <james.morse@....com>,
"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/19] EDAC, mc: Reduce indentation level in
edac_mc_handle_error()
On Thu, 2019-10-10 at 20:25 +0000, Robert Richter wrote:
> Reduce the indentation level in edac_mc_handle_error() a bit by using
> continue. No functional changes.
Seems fine, but trivially below:
> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
[]
> @@ -1171,37 +1171,38 @@ void edac_mc_handle_error(const enum hw_event_mc_err_type type,
[]
> + strcpy(p, dimm->label);
> + p += strlen(p);
> + *p = '\0';
This *p = '\0' is unnecessary as the strcpy already did that.
Powered by blists - more mailing lists