linux-kernel - RE: [PATCH 2/2] net: fec_ptp: Use platform_get_irq_xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Oct 2019 06:55:32 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Anson Huang <anson.huang@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "swboyd@...omium.org" <swboyd@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 2/2] net: fec_ptp: Use platform_get_irq_xxx_optional() to
 avoid error message

From: Anson Huang <Anson.Huang@....com> Sent: Wednesday, October 9, 2019 6:16 PM
> Use platform_get_irq_byname_optional() and platform_get_irq_optional()
> instead of platform_get_irq_byname() and platform_get_irq() for optional
> IRQs to avoid below error message during probe:
> 
> [    0.795803] fec 30be0000.ethernet: IRQ pps not found
> [    0.800787] fec 30be0000.ethernet: IRQ index 3 not found
> 
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to
> platform_get_irq*()")
> Signed-off-by: Anson Huang <Anson.Huang@....com>

Acked-by: Fugang Duan <fugang.duan@....com>
> ---
>  drivers/net/ethernet/freescale/fec_ptp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index 19e2365..945643c 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -600,9 +600,9 @@ void fec_ptp_init(struct platform_device *pdev, int
> irq_idx)
> 
>  	INIT_DELAYED_WORK(&fep->time_keep, fec_time_keep);
> 
> -	irq = platform_get_irq_byname(pdev, "pps");
> +	irq = platform_get_irq_byname_optional(pdev, "pps");
>  	if (irq < 0)
> -		irq = platform_get_irq(pdev, irq_idx);
> +		irq = platform_get_irq_optional(pdev, irq_idx);
>  	/* Failure to get an irq is not fatal,
>  	 * only the PTP_CLOCK_PPS clock events should stop
>  	 */
> --
> 2.7.4