[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 10 Oct 2019 11:31:10 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 0/2] extcon: axp288: Move to swnodes
On Tue, Oct 08, 2019 at 05:02:04PM +0300, Heikki Krogerus wrote:
> On Tue, Oct 08, 2019 at 03:59:23PM +0200, Hans de Goede wrote:
> > Hi,
> >
> > On 08-10-2019 14:25, Heikki Krogerus wrote:
> > > Hi Hans,
> > >
> > > Fixed the compiler warning in this version. No other changes.
> > >
> > > The original cover letter:
> > >
> > > That AXP288 extcon driver is the last that uses build-in connection
> > > description. I'm replacing it with a code that finds the role mux
> > > software node instead.
> > >
> > > I'm proposing also here a little helper
> > > usb_role_switch_find_by_fwnode() that uses
> > > class_find_device_by_fwnode() to find the role switches.
> >
> > Both patches look good to me and I can confirm that things still
> > work as they should on a CHT device with an AXP288 PMIC, so for both:
> >
> > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> > Tested-by: Hans de Goede <hdegoede@...hat.com>
> >
> > Regards,
> >
> > Hans
> >
> > p.s.
> >
> > I guess this means we can remove the build-in connection (
> > device_connection_add / remove) stuff now?
>
> Yes. I'll prepare separate patches for that.
Actually, maybe it would make sense to just remove it in this series.
I'm attaching a patch that remove struct device_connection completely.
Can you check if it makes sense to you?
thanks,
--
heikki
View attachment "0001-device-connection-Remove-struct-device_connection.patch" of type "text/plain" (15829 bytes)
Powered by blists - more mailing lists