[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 10 Oct 2019 12:53:35 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Yizhuo <yzhai003@....edu>
Cc: devel@...verdev.osuosl.org, linux-fbdev@...r.kernel.org,
Teddy Wang <teddy.wang@...iconmotion.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"
On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote:
> Inside function set_chip_clock(), struct pll is supposed to be
> initialized in sm750_calc_pll_value(), if condition
> "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled,
> then some field of pll will not be initialized but used in
> function sm750_format_pll_reg(), which is potentially unsafe.
>
> Signed-off-by: Yizhuo <yzhai003@....edu>
The patch is correct, but it doesn't apply to linux-next any more. Can
you re-write it on top of the most recent staging-next and resend?
regards,
dan carpenter
Powered by blists - more mailing lists