| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Oct 2019 10:05:29 +0000
From: Changwei Ge <gechangwei@...e.cn>
To: Joseph Qi <jiangqi903@...il.com>,
Chengguang Xu <cgxu519@...ernel.net>,
"ocfs2-devel@....oracle.com" <ocfs2-devel@....oracle.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Ocfs2-devel] (RESEND) [PATCH] ocfs2: Fix error handling in
ocfs2_setattr()
On 2019/10/10 4:49 下午, Joseph Qi wrote:
>
> On 19/10/10 16:23, Chengguang Xu wrote:
>> Should set transfer_to[USRQUOTA/GRPQUOTA] to NULL
>> on error case before jump to do dqput().
>>
>> Signed-off-by: Chengguang Xu <cgxu519@...ernel.net>
> Looks good.
>
> Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
Also looks sane to me
Reviewed-by: Changwei Ge <chge@...ux.alibaba.com>
>> ---
>> fs/ocfs2/file.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
>> index 2e982db3e1ae..53939bf9d7d2 100644
>> --- a/fs/ocfs2/file.c
>> +++ b/fs/ocfs2/file.c
>> @@ -1230,6 +1230,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr)
>> transfer_to[USRQUOTA] = dqget(sb, make_kqid_uid(attr->ia_uid));
>> if (IS_ERR(transfer_to[USRQUOTA])) {
>> status = PTR_ERR(transfer_to[USRQUOTA]);
>> + transfer_to[USRQUOTA] = NULL;
>> goto bail_unlock;
>> }
>> }
>> @@ -1239,6 +1240,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr)
>> transfer_to[GRPQUOTA] = dqget(sb, make_kqid_gid(attr->ia_gid));
>> if (IS_ERR(transfer_to[GRPQUOTA])) {
>> status = PTR_ERR(transfer_to[GRPQUOTA]);
>> + transfer_to[GRPQUOTA] = NULL;
>> goto bail_unlock;
>> }
>> }
>>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@....oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
Powered by blists - more mailing lists