[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 10 Oct 2019 15:50:43 +0200
From: Daniel Vetter <daniel@...ll.ch>
To: Johan Hovold <johan@...nel.org>
Cc: Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
Fabien Dessenne <fabien.dessenne@...com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Harald Freudenberger <freude@...ux.ibm.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Heiko Carstens <heiko.carstens@...ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>,
Christian Borntraeger <borntraeger@...ibm.com>,
linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, linux-s390@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 0/4] treewide: fix interrupted release
On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote:
> Two old USB drivers had a bug in them which could lead to memory leaks
> if an interrupted process raced with a disconnect event.
>
> Turns out we had a few more driver in other subsystems with the same
> kind of bug in them.
>
> Note that all but the s390 patch have only been compile tested, while
> the s390 one has not even been built.
Random funny idea: Could we do some debug annotations (akin to
might_sleep) that splats when you might_sleep_interruptible somewhere
where interruptible sleeps are generally a bad idea? Like in
fops->release?
Something like non_block_start/end that I've recently done, but for
interruptible sleeps only? Would need might_sleep_interruptibly()
annotations and non_interruptly_sleep_start/end annotations.
-Daniel
>
> Johan
>
>
> Johan Hovold (4):
> drm/msm: fix memleak on release
> media: bdisp: fix memleak on release
> media: radio: wl1273: fix interrupt masking on release
> s390/zcrypt: fix memleak at release
>
> drivers/gpu/drm/msm/msm_debugfs.c | 6 +-----
> drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +--
> drivers/media/radio/radio-wl1273.c | 3 +--
> drivers/s390/crypto/zcrypt_api.c | 3 +--
> 4 files changed, 4 insertions(+), 11 deletions(-)
>
> --
> 2.23.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Powered by blists - more mailing lists