lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Oct 2019 17:03:57 +0300 From: "Hawa, Hanna" <hhhawa@...zon.com> To: Rob Herring <robh+dt@...nel.org> CC: Borislav Petkov <bp@...en8.de>, Mauro Carvalho Chehab <mchehab@...nel.org>, Mark Rutland <mark.rutland@....com>, James Morse <james.morse@....com>, Frank Rowand <frowand.list@...il.com>, David Miller <davem@...emloft.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Linus Walleij" <linus.walleij@...aro.org>, <daniel@...earbox.net>, "Paul E. McKenney" <paulmck@...ux.ibm.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-edac <linux-edac@...r.kernel.org>, <devicetree@...r.kernel.org>, "Woodhouse, David" <dwmw@...zon.co.uk>, <benh@...zon.com>, "Krupnik, Ronen" <ronenk@...zon.com>, Talel Shenhar <talel@...zon.com>, Jonathan Chocron <jonnyc@...zon.com>, "Hanoch, Uri" <hanochu@...zon.com> Subject: Re: [PATCH v6 3/3] edac: Add support for Amazon's Annapurna Labs L2 EDAC Hi, On 10/10/2019 2:19 AM, Rob Herring wrote: > On Mon, Oct 7, 2019 at 10:18 AM Hanna Hawa <hhhawa@...zon.com> wrote: >> >> Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and >> report L2 errors. >> >> Signed-off-by: Hanna Hawa <hhhawa@...zon.com> >> --- >> MAINTAINERS | 5 + >> drivers/edac/Kconfig | 8 ++ >> drivers/edac/Makefile | 1 + >> drivers/edac/al_l2_edac.c | 251 ++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 265 insertions(+) >> create mode 100644 drivers/edac/al_l2_edac.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 7887a62dc843..0eabcfcf91a9 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -748,6 +748,11 @@ M: Hanna Hawa <hhhawa@...zon.com> >> S: Maintained >> F: drivers/edac/al_l1_edac.c >> >> +AMAZON ANNAPURNA LABS L2 EDAC >> +M: Hanna Hawa <hhhawa@...zon.com> >> +S: Maintained >> +F: drivers/edac/al_l2_edac.c >> + >> AMAZON ANNAPURNA LABS THERMAL MMIO DRIVER >> M: Talel Shenhar <talel@...zon.com> >> S: Maintained >> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig >> index e8161d7c7469..cb394aff1cab 100644 >> --- a/drivers/edac/Kconfig >> +++ b/drivers/edac/Kconfig >> @@ -82,6 +82,14 @@ config EDAC_AL_L1 >> for Amazon's Annapurna Labs SoCs. >> This driver detects errors of L1 caches. >> >> +config EDAC_AL_L2 >> + tristate "Amazon's Annapurna Labs L2 EDAC" > > I still think this should be an "A57 L2 ECC" driver, but if no one > cares I'll shut up and the 2nd person can rename everything. > >> + depends on ARCH_ALPINE > > || COMPILE_TEST Will be add in next patchset. > > Maybe it needs an ARM64 dependency too in this case? Yes, it need ARM64 dependency, I'll add. Thanks, Hanna > >> + help >> + Support for L2 error detection and correction >> + for Amazon's Annapurna Labs SoCs. >> + This driver detects errors of L2 caches. >> + > >> + >> + ret = platform_driver_register(&al_l2_edac_driver); >> + if (ret) { >> + pr_err("Failed to register %s (%d)\n", DRV_NAME, ret); >> + return ret; >> + } >> + >> + edac_l2_device = platform_device_register_simple(DRV_NAME, -1, NULL, 0); >> + if (IS_ERR(edac_l2_device)) { >> + pr_err("Failed to register EDAC AL L2 platform device\n"); >> + return PTR_ERR(edac_l2_device); >> + } >> + >> + return 0; >> +} >> + >> +static void __exit al_l2_exit(void) >> +{ >> + platform_device_unregister(edac_l2_device); >> + platform_driver_unregister(&al_l2_edac_driver); >> +} >> + >> +late_initcall(al_l2_init); >> +module_exit(al_l2_exit); >> + >> +MODULE_LICENSE("GPL v2"); >> +MODULE_AUTHOR("Hanna Hawa <hhhawa@...zon.com>"); >> +MODULE_DESCRIPTION("Amazon's Annapurna Lab's L2 EDAC Driver"); >> -- >> 2.17.1 >>
Powered by blists - more mailing lists