linux-kernel - RE: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Oct 2019 14:54:59 +0000
From:   Matt Sickler <Matt.Sickler@...tronics.com>
To:     Chandra Annamaneni <chandra627@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "gneukum1@...il.com" <gneukum1@...il.com>,
        "fabian.krueger@....de" <fabian.krueger@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "simon@...anor.nu" <simon@...anor.nu>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>
Subject: RE: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)

>-----Original Message-----
>From: devel <driverdev-devel-bounces@...uxdriverproject.org> On Behalf Of Chandra Annamaneni
>Sent: Wednesday, October 09, 2019 10:09 PM
>To: gregkh@...uxfoundation.org
>Cc: devel@...verdev.osuosl.org; gneukum1@...il.com; chandra627@...il.com; fabian.krueger@....de; linux-
>kernel@...r.kernel.org; simon@...anor.nu; dan.carpenter@...cle.com
>Subject: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)
>
>Resoved: "WARNING: line over 80 characters" from checkpatch.pl
>
>Signed-off-by: Chandra Annamaneni <chandra627@...il.com>
>---
> drivers/staging/kpc2000/kpc2000_spi.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
>index 3be33c4..ef78b6d 100644
>--- a/drivers/staging/kpc2000/kpc2000_spi.c
>+++ b/drivers/staging/kpc2000/kpc2000_spi.c
>@@ -30,19 +30,19 @@
> #include "kpc.h"
>
> static struct mtd_partition p2kr0_spi0_parts[] = {
>-       { .name = "SLOT_0",     .size = 7798784,                .offset = 0,                },
>-       { .name = "SLOT_1",     .size = 7798784,                .offset = MTDPART_OFS_NXTBLK},
>-       { .name = "SLOT_2",     .size = 7798784,                .offset = MTDPART_OFS_NXTBLK},
>-       { .name = "SLOT_3",     .size = 7798784,                .offset = MTDPART_OFS_NXTBLK},
>-       { .name = "CS0_EXTRA",  .size = MTDPART_SIZ_FULL,       .offset = MTDPART_OFS_NXTBLK},
>+       { .name = "SLOT_0",  .size = 7798784,  .offset = 0,},
>+       { .name = "SLOT_1",  .size = 7798784,  .offset = MTDPART_OFS_NXTBLK},
>+       { .name = "SLOT_2",  .size = 7798784,  .offset = MTDPART_OFS_NXTBLK},
>+       { .name = "SLOT_3",  .size = 7798784,  .offset = MTDPART_OFS_NXTBLK},
>+       { .name = "CS0_EXTRA", .size = MTDPART_SIZ_FULL, .offset = MTDPART_OFS_NXTBLK},
> };
>
> static struct mtd_partition p2kr0_spi1_parts[] = {
>-       { .name = "SLOT_4",     .size = 7798784,                .offset = 0,                },
>-       { .name = "SLOT_5",     .size = 7798784,                .offset = MTDPART_OFS_NXTBLK},
>-       { .name = "SLOT_6",     .size = 7798784,                .offset = MTDPART_OFS_NXTBLK},
>-       { .name = "SLOT_7",     .size = 7798784,                .offset = MTDPART_OFS_NXTBLK},
>-       { .name = "CS1_EXTRA",  .size = MTDPART_SIZ_FULL,       .offset = MTDPART_OFS_NXTBLK},
>+       { .name = "SLOT_4",  .size = 7798784,  .offset = 0,},
>+       { .name = "SLOT_5",  .size = 7798784,  .offset = MTDPART_OFS_NXTBLK},
>+       { .name = "SLOT_6",  .size = 7798784,  .offset = MTDPART_OFS_NXTBLK},
>+       { .name = "SLOT_7",  .size = 7798784,  .offset = MTDPART_OFS_NXTBLK},
>+       { .name = "CS1_EXTRA",  .size = MTDPART_SIZ_FULL, .offset = MTDPART_OFS_NXTBLK},
> };
>
> static struct flash_platform_data p2kr0_spi0_pdata = {

Is the line length limit a hard rule or can exceptions be made?  I really feel that these data tables are more easily read when they're formatted like tables...