linux-kernel - Re: [PATCH v2] xen: Stop abusing DT of_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Oct 2019 11:44:14 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Oleksandr Andrushchenko <Oleksandr_Andrushchenko@...m.com>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Robin Murphy <robin.murphy@....com>,
        Julien Grall <julien.grall@....com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2] xen: Stop abusing DT of_dma_configure API

On 10/10/19 11:32 AM, Rob Herring wrote:
> On Thu, Oct 10, 2019 at 9:00 AM Boris Ostrovsky
> <boris.ostrovsky@...cle.com> wrote:
>> On 10/9/19 7:42 AM, Oleksandr Andrushchenko wrote:
>>> On 10/8/19 10:41 PM, Rob Herring wrote:
>>>> As the removed comments say, these aren't DT based devices.
>>>> of_dma_configure() is going to stop allowing a NULL DT node and calling
>>>> it will no longer work.
>>>>
>>>> The comment is also now out of date as of commit 9ab91e7c5c51 ("arm64:
>>>> default to the direct mapping in get_arch_dma_ops"). Direct mapping
>>>> is now the default rather than dma_dummy_ops.
>>>>
>>>> According to Stefano and Oleksandr, the only other part needed is
>>>> setting the DMA masks and there's no reason to restrict the masks to
>>>> 32-bits. So set the masks to 64 bits.
>>>>
>>>> Cc: Robin Murphy <robin.murphy@....com>
>>>> Cc: Julien Grall <julien.grall@....com>
>>>> Cc: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
>>>> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
>>>> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
>>>> Cc: Juergen Gross <jgross@...e.com>
>>>> Cc: Stefano Stabellini <sstabellini@...nel.org>
>>>> Cc: Christoph Hellwig <hch@....de>
>>>> Cc: xen-devel@...ts.xenproject.org
>>>> Signed-off-by: Rob Herring <robh@...nel.org>
>>> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
>>
>> Is this going to go via drm tree or should I pick it up for Xen tree?
> Please apply to the Xen tree.

Ok. FTR,

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>