[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 10 Oct 2019 13:07:18 -0300
From: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To: Jiri Olsa <jolsa@...hat.com>
Cc: Jiri Olsa <jolsa@...nel.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Michael Petlan <mpetlan@...hat.com>,
Namhyung Kim <namhyung@...nel.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
lkml <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 12/36] libperf: Add perf_mmap__read_event() function
Em Thu, Oct 10, 2019 at 05:32:32PM +0200, Jiri Olsa escreveu:
> On Thu, Oct 10, 2019 at 11:47:00AM -0300, Arnaldo Carvalho de Melo wrote:
>
> SNIP
>
> > > diff --git a/tools/perf/lib/include/internal/mmap.h b/tools/perf/lib/include/internal/mmap.h
> > > index ee536c4441bb..b328332b6ccf 100644
> > > --- a/tools/perf/lib/include/internal/mmap.h
> > > +++ b/tools/perf/lib/include/internal/mmap.h
> > > @@ -11,6 +11,7 @@
> > > #define PERF_SAMPLE_MAX_SIZE (1 << 16)
> > >
> > > struct perf_mmap;
> > > +union perf_event;
> >
> > Why are you adding this here?
>
> oops, it should be in lib/include/perf/mmap.h ;-)
> plz let me know if you want me to repost
I fixed it already, its in acme/tmp.perf/core, will continue later,
possibly will push to Ingo what I have there if it passes all the
tests, its getting too big a perf/core. :-)
- Arnaldo
Powered by blists - more mailing lists