linux-kernel - Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191010164847.ntbhecap6pbesvk7@earth.universe>
Date:   Thu, 10 Oct 2019 18:48:47 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kukjin Kim <kgene@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four
 spaces

Hi,

On Wed, Oct 02, 2019 at 06:07:41PM +0200, Krzysztof Kozlowski wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Acked-by: Sebastian Reichel <sre@...nel.org> # for power/reset

-- Sebastian

> ---
>  .../bindings/arm/samsung/exynos-chipid.yaml   |  4 +-
>  .../bindings/iio/adc/samsung,exynos-adc.yaml  | 64 +++++++++----------
>  .../bindings/power/reset/syscon-poweroff.yaml |  8 +--
>  .../bindings/power/reset/syscon-reboot.yaml   |  8 +--
>  .../devicetree/bindings/rtc/s3c-rtc.yaml      | 12 ++--
>  5 files changed, 48 insertions(+), 48 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
>  examples:
>    - |
>      chipid@...00000 {
> -      compatible = "samsung,exynos4210-chipid";
> -      reg = <0x10000000 0x100>;
> +        compatible = "samsung,exynos4210-chipid";
> +        reg = <0x10000000 0x100>;
>      };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
>  examples:
>    - |
>      adc: adc@...10000 {
> -      compatible = "samsung,exynos-adc-v1";
> -      reg = <0x12d10000 0x100>;
> -      interrupts = <0 106 0>;
> -      #io-channel-cells = <1>;
> -      io-channel-ranges;
> -
> -      clocks = <&clock 303>;
> -      clock-names = "adc";
> -
> -      vdd-supply = <&buck5_reg>;
> -      samsung,syscon-phandle = <&pmu_system_controller>;
> -
> -      /* NTC thermistor is a hwmon device */
> -      ncp15wb473@0 {
> -        compatible = "murata,ncp15wb473";
> -        pullup-uv = <1800000>;
> -        pullup-ohm = <47000>;
> -        pulldown-ohm = <0>;
> -        io-channels = <&adc 4>;
> -      };
> +        compatible = "samsung,exynos-adc-v1";
> +        reg = <0x12d10000 0x100>;
> +        interrupts = <0 106 0>;
> +        #io-channel-cells = <1>;
> +        io-channel-ranges;
> +
> +        clocks = <&clock 303>;
> +        clock-names = "adc";
> +
> +        vdd-supply = <&buck5_reg>;
> +        samsung,syscon-phandle = <&pmu_system_controller>;
> +
> +        /* NTC thermistor is a hwmon device */
> +        ncp15wb473@0 {
> +            compatible = "murata,ncp15wb473";
> +            pullup-uv = <1800000>;
> +            pullup-ohm = <47000>;
> +            pulldown-ohm = <0>;
> +            io-channels = <&adc 4>;
> +          };
>      };
>  
>    - |
>      adc@...c0000 {
> -      compatible = "samsung,exynos3250-adc";
> -      reg = <0x126C0000 0x100>;
> -      interrupts = <0 137 0>;
> -      #io-channel-cells = <1>;
> -      io-channel-ranges;
> -
> -      clocks = <&cmu 0>, // CLK_TSADC
> -               <&cmu 1>; // CLK_SCLK_TSADC
> -      clock-names = "adc", "sclk";
> -
> -      vdd-supply = <&buck5_reg>;
> -      samsung,syscon-phandle = <&pmu_system_controller>;
> +        compatible = "samsung,exynos3250-adc";
> +        reg = <0x126C0000 0x100>;
> +        interrupts = <0 137 0>;
> +        #io-channel-cells = <1>;
> +        io-channel-ranges;
> +
> +        clocks = <&cmu 0>, // CLK_TSADC
> +                 <&cmu 1>; // CLK_SCLK_TSADC
> +        clock-names = "adc", "sclk";
> +
> +        vdd-supply = <&buck5_reg>;
> +        samsung,syscon-phandle = <&pmu_system_controller>;
>      };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
>  examples:
>    - |
>      poweroff {
> -      compatible = "syscon-poweroff";
> -      regmap = <&regmapnode>;
> -      offset = <0x0>;
> -      mask = <0x7a>;
> +        compatible = "syscon-poweroff";
> +        regmap = <&regmapnode>;
> +        offset = <0x0>;
> +        mask = <0x7a>;
>      };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
>  examples:
>    - |
>      reboot {
> -      compatible = "syscon-reboot";
> -      regmap = <&regmapnode>;
> -      offset = <0x0>;
> -      mask = <0x1>;
> +        compatible = "syscon-reboot";
> +        regmap = <&regmapnode>;
> +        offset = <0x0>;
> +        mask = <0x1>;
>      };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
>  examples:
>    - |
>      rtc@...70000 {
> -      compatible = "samsung,s3c6410-rtc";
> -      reg = <0x10070000 0x100>;
> -      interrupts = <0 44 4>, <0 45 4>;
> -      clocks = <&clock 0>, // CLK_RTC
> -               <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> -      clock-names = "rtc", "rtc_src";
> +        compatible = "samsung,s3c6410-rtc";
> +        reg = <0x10070000 0x100>;
> +        interrupts = <0 44 4>, <0 45 4>;
> +        clocks = <&clock 0>, // CLK_RTC
> +                 <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> +        clock-names = "rtc", "rtc_src";
>      };
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)