linux-kernel - Re: [PATCH] staging: wfx: fix an undefined reference error when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191011042609.GB938845@kroah.com>
Date:   Fri, 11 Oct 2019 06:26:09 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     jerome.pouiller@...abs.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wfx: fix an undefined reference error when
 CONFIG_MMC=m

On Fri, Oct 11, 2019 at 11:02:19AM +0800, zhong jiang wrote:
> I hit the following error when compile the kernel.
> 
> drivers/staging/wfx/main.o: In function `wfx_core_init':
> /home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:488: undefined reference to `sdio_register_driver'
> drivers/staging/wfx/main.o: In function `wfx_core_exit':
> /home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:496: undefined reference to `sdio_unregister_driver'
> drivers/staging/wfx/main.o:(.debug_addr+0x1a8): undefined reference to `sdio_register_driver'
> drivers/staging/wfx/main.o:(.debug_addr+0x6f0): undefined reference to `sdio_unregister_driver'
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/staging/wfx/Kconfig  | 3 ++-
>  drivers/staging/wfx/Makefile | 5 +++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wfx/Kconfig b/drivers/staging/wfx/Kconfig
> index 9b8a1c7..4d045513 100644
> --- a/drivers/staging/wfx/Kconfig
> +++ b/drivers/staging/wfx/Kconfig
> @@ -1,7 +1,8 @@
>  config WFX
>  	tristate "Silicon Labs wireless chips WF200 and further"
>  	depends on MAC80211
> -	depends on (SPI || MMC)
> +	depends on SPI
> +	select MMC

How about:
	depends on (SPI && MMC)

instead?

thanks,

greg k-h