linux-kernel - Re: [PATCH v5 bpf-next 09/15] samples/bpf: use own flags but not HOSTCFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99f76e2f-ed76-77e0-a470-36ae07567111@cogentembedded.com>
Date:   Fri, 11 Oct 2019 11:49:38 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>, ast@...nel.org,
        daniel@...earbox.net, yhs@...com, davem@...emloft.net,
        jakub.kicinski@...ronome.com, hawk@...nel.org,
        john.fastabend@...il.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, clang-built-linux@...glegroups.com,
        ilias.apalodimas@...aro.org
Subject: Re: [PATCH v5 bpf-next 09/15] samples/bpf: use own flags but not
 HOSTCFLAGS

    More grammar nitpicking...

On 11.10.2019 3:28, Ivan Khoronzhuk wrote:

> While compiling natively, the host's cflags and ldflags are equal to
> ones used from HOSTCFLAGS and HOSTLDFLAGS. When cross compiling it
> should have own, used for target arch. While verification, for arm,

    While verifying.

> arm64 and x86_64 the following flags were used always:
> 
> -Wall -O2
> -fomit-frame-pointer
> -Wmissing-prototypes
> -Wstrict-prototypes
> 
> So, add them as they were verified and used before adding
> Makefile.target and lets omit "-fomit-frame-pointer" as were proposed
> while review, as no sense in such optimization for samples.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
[...]

MBR, Sergei