linux-kernel - Re: [PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191011091110.GA1124173@kroah.com>
Date:   Fri, 11 Oct 2019 11:11:10 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chandra Annamaneni <chandra627@...il.com>
Cc:     devel@...verdev.osuosl.org, gneukum1@...il.com,
        michael.scheiderer@....de, fabian.krueger@....de,
        linux-kernel@...r.kernel.org,
        Simon Sandström <simon@...anor.nu>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing
 blank line)

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, Oct 11, 2019 at 02:02:32AM -0700, Chandra Annamaneni wrote:
> The first set of patches were in a single commit. I started from scratch
> and built these patches from 5 different commits. Don't know if the first
> set of patches are relevant anymore.

They are not relevant to being applied, but this patch series has
changed based on the comments you received from the previous patch(s).
So it is relevant to how you got to this set of patches.

This makes it easier for reviewers to understand what changed and what
they need to focus on, or ignore, in your new set of patches.  This
isn't for you, it is for the people you are sending these patches to.

thanks,

greg k-h