linux-kernel - Re: [Patch v7 1/4] tpm: Move tpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191011114105.GA3129@linux.intel.com>
Date:   Fri, 11 Oct 2019 14:41:05 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Sumit Garg <sumit.garg@...aro.org>
Cc:     dhowells@...hat.com, peterhuewe@....de, keyrings@...r.kernel.org,
        linux-integrity@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-security-module@...r.kernel.org, herbert@...dor.apana.org.au,
        davem@...emloft.net, jgg@...pe.ca, arnd@...db.de,
        gregkh@...uxfoundation.org, jejb@...ux.ibm.com,
        zohar@...ux.ibm.com, jmorris@...ei.org, serge@...lyn.com,
        jsnitsel@...hat.com, linux-kernel@...r.kernel.org,
        daniel.thompson@...aro.org
Subject: Re: [Patch v7 1/4] tpm: Move tpm_buf code to include/linux/

On Mon, Oct 07, 2019 at 10:55:32AM +0530, Sumit Garg wrote:
> Move tpm_buf code to common include/linux/tpm.h header so that it can
> be reused via other subsystems like trusted keys etc.
> 
> Also rename trusted keys and asymmetric keys usage of TPM 1.x buffer
> implementation to tpm1_buf to avoid any compilation errors.
> 
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@...aro.org>
> ---
>  crypto/asymmetric_keys/asym_tpm.c |  12 +--
>  drivers/char/tpm/tpm.h            | 215 --------------------------------------
>  include/keys/trusted.h            |  12 +--
>  include/linux/tpm.h               | 215 ++++++++++++++++++++++++++++++++++++++
>  security/keys/trusted.c           |  12 +--
>  5 files changed, 233 insertions(+), 233 deletions(-)

Looks clean.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

/Jarkko