linux-kernel - Re: [PATCH] x86/asm: Make more symbols local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191011124544.GA8824@zn.tnic>
Date:   Fri, 11 Oct 2019 14:45:44 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/asm: Make more symbols local

On Fri, Oct 11, 2019 at 11:22:13AM +0200, Jiri Slaby wrote:
> During the assembly cleanup patchset reveiew, I found more symbols which

"review"

> are used only locally. So make them really local by prepending ".L" to
> them. Namely:
> * wakeup_idt is used only in realmode/rm/wakeup_asm.S.
> * in_pm32 is used only in boot/pmjump.S.
> * retint_user is used only in entry/entry_64.S, perhaps since commit
>   2ec67971facc ("x86/entry/64/compat: Remove most of the fast system
>   call machinery"), where entry_64_compat's caller was removed.
> 
> Drop GLOBAL from all of them too. I do not see more candidates in the
> series.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: x86@...nel.org
> ---
>  arch/x86/boot/pmjump.S            | 6 +++---
>  arch/x86/entry/entry_64.S         | 4 ++--
>  arch/x86/realmode/rm/wakeup_asm.S | 6 +++---
>  3 files changed, 8 insertions(+), 8 deletions(-)

other than that:

Acked-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette