linux-kernel - Re: [PATCH] xfs: fix wrong struct type in ioctl definition whih cmd XFS_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191011130615.GA27614@infradead.org>
Date:   Fri, 11 Oct 2019 06:06:15 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     yu kuai <yukuai3@...wei.com>
Cc:     darrick.wong@...cle.com, bfoster@...hat.com, dchinner@...hat.com,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhengbin13@...wei.com, yi.zhang@...wei.com, zhangxiaoxu5@...wei.com
Subject: Re: [PATCH] xfs: fix wrong struct type in ioctl definition whih cmd
 XFS_IOC_GETBMAPAX

On Fri, Oct 11, 2019 at 07:14:46PM +0800, yu kuai wrote:
> ioctl expect 'getbmapx' as the 'arg' when the cmd is XFS_IOC_GETBMAPX.
> But the definition in 'xfs_fs.h' is 'getbmap'

Strictly speaking that is true.  But changing this defintion will break
existing userspace given that _IOWR encodes the structure size.  If you
had reported this 16 years earlier we could have fixed it.