linux-kernel - Re: [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191011141823.kyxz32c2p24rr3d3@ti.com>
Date:   Fri, 11 Oct 2019 09:18:23 -0500
From:   Benoit Parrot <bparrot@...com>
To:     Colin King <colin.king@...onical.com>
CC:     Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        <linux-media@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r,
 copy-paste error

Colin King <colin.king@...onical.com> wrote on Fri [2019-Oct-11 14:29:40 +0100]:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There appears to be a copy-paste error on the access of
> csc_coeffs.y2r.r601.full.coeff, I believe csc_coeffs.2yr.r601.full.coeff
> should be used instead. This is a moot point as the code is never
> reached, but at least use the correct structure element.
> 
> Addresses-Coverity: ("Copy-paste error")
> Fixes: 3ff3a712a9ea ("media: ti-vpe: vpe: don't rely on colorspace member for conversion")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/media/platform/ti-vpe/csc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c
> index bd923bee4a31..834114a4eebe 100644
> --- a/drivers/media/platform/ti-vpe/csc.c
> +++ b/drivers/media/platform/ti-vpe/csc.c
> @@ -238,7 +238,7 @@ void csc_set_coeff(struct csc_data *csc, u32 *csc_reg0,
>  				coeff = csc_coeffs.r2y.r709.limited.coeff;
>  		} else {
>  			/* Should never reach this, but it keeps gcc happy */
> -			coeff = csc_coeffs.y2r.r601.full.coeff;
> +			coeff = csc_coeffs.r2y.r601.full.coeff;
>  		}
>  	} else {
>  		*csc_reg5 |= CSC_BYPASS;

Reviewed-by: Benoit Parrot <bparrot.ti.com>

> -- 
> 2.20.1
>