linux-kernel - [PATCH] arm: topology: only build cpu_corepower

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191011164142.659-1-ben.dooks@codethink.co.uk>
Date:   Fri, 11 Oct 2019 17:41:42 +0100
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     linux-kernel@...ts.codethink.co.uk
Cc:     Ben Dooks <ben.dooks@...ethink.co.uk>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] arm: topology: only build cpu_corepower_mask if needed

The cpu_corepower_mask() is only needed if CONFIG_SCHED_MC is
enabled, so remove the warning about it not being used by
ifdef-ing it out.

fixes the following build warning:

arch/arm/kernel/topology.c:184:30: warning: ‘cpu_corepower_mask’ defined but not used [-Wunused-function]
  184 | static const struct cpumask *cpu_corepower_mask(int cpu)

Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
---
KernelVersion: 5.4-rc3

Cc: Russell King <linux@...linux.org.uk>
Cc: linux-kernel@...r.kernel.org
---
 arch/arm/kernel/topology.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
index 05d4223d5493..61f9a28f4bfb 100644
--- a/arch/arm/kernel/topology.c
+++ b/arch/arm/kernel/topology.c
@@ -177,6 +177,7 @@ static inline void parse_dt_topology(void) {}
 static inline void update_cpu_capacity(unsigned int cpuid) {}
 #endif
 
+#ifdef CONFIG_SCHED_MC
 /*
  * The current assumption is that we can power gate each core independently.
  * This will be superseded by DT binding once available.
@@ -185,6 +186,7 @@ static const struct cpumask *cpu_corepower_mask(int cpu)
 {
 	return &cpu_topology[cpu].thread_sibling;
 }
+#endif
 
 /*
  * store_cpu_topology is called at boot when only one cpu is running
-- 
2.23.0