linux-kernel - Re: [PATCH] cgroup: freezer: call cgroup_enter_frozen() with preemption disabled in ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191011165213.GB18794@devbig004.ftw2.facebook.com>
Date:   Fri, 11 Oct 2019 09:52:13 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Roman Gushchin <guro@...com>,
        Richard Purdie <richard.purdie@...uxfoundation.org>,
        Bruce Ashfield <bruce.ashfield@...il.com>
Subject: Re: [PATCH] cgroup: freezer: call cgroup_enter_frozen() with
 preemption disabled in ptrace_stop()

On Wed, Oct 09, 2019 at 05:02:30PM +0200, Oleg Nesterov wrote:
> ptrace_stop() does preempt_enable_no_resched() to avoid the preemption,
> but after that cgroup_enter_frozen() does spin_lock/unlock and this adds
> another preemption point.
> 
> Reported-and-tested-by: Bruce Ashfield <bruce.ashfield@...il.com>
> Fixes: 76f969e8948d ("cgroup: cgroup v2 freezer")
> Cc: stable@...r.kernel.org # v5.2+
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Applied to cgroup/for-5.4-fixes.

Thanks.

-- 
tejun