linux-kernel - Re: [PATCH v3 1/3] x86/boot: Introduce the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191011184357.GI691@char.us.oracle.com>
Date:   Fri, 11 Oct 2019 14:43:57 -0400
From:   Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Daniel Kiper <daniel.kiper@...cle.com>, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        xen-devel@...ts.xenproject.org, ard.biesheuvel@...aro.org,
        boris.ostrovsky@...cle.com, bp@...en8.de, corbet@....net,
        dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
        eric.snowberg@...cle.com, hpa@...or.com, jgross@...e.com,
        mingo@...hat.com, ross.philipson@...cle.com, tglx@...utronix.de
Subject: Re: [PATCH v3 1/3] x86/boot: Introduce the kernel_info

> >>> +be prefixed with header/magic and its size, e.g.:
> >>> +
> >>> +  kernel_info:
> >>> +          .ascii  "LToP"          /* Header, Linux top (structure). */
> >>> +          .long   kernel_info_var_len_data - kernel_info
> >>> +          .long   kernel_info_end - kernel_info
> >>> +          .long   0x01234567      /* Some fixed size data for the bootloaders. */
> >>> +  kernel_info_var_len_data:
> >>> +  example_struct:                 /* Some variable size data for the bootloaders. */
> >>> +          .ascii  "EsTT"          /* Header/Magic. */
> >>> +          .long   example_struct_end - example_struct
> >>> +          .ascii  "Struct"
> >>> +          .long   0x89012345
> >>> +  example_struct_end:
> >>> +  example_strings:                /* Some variable size data for the bootloaders. */
> >>> +          .ascii  "EsTs"          /* Header/Magic. */
> >>
> >> Where do the Magic values "EsTT" and "EsTs" come from?
> >> where are they defined?
> > 
> > EsTT == Example STrucT
> > EsTs == Example STringS
> > 
> > Anyway, it can be anything which does not collide with existing variable
> > length data magics. There are none right now. So, it can be anything.
> > Maybe I should add something saying that.
> 
> Yes, please.

Or make it very clear they are examples, says "1234" or "ABCD" or such.

> 
> thanks.
> -- 
> ~Randy