linux-kernel - Re: [PATCH v2 2/2] iio: (bma400) add driver for the BMA400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191012102917.7e85275f@archlinux>
Date:   Sat, 12 Oct 2019 10:29:17 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Dan Robertson <dan@...obertson.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        devicetree <devicetree@...r.kernel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: (bma400) add driver for the BMA400

On Sat, 12 Oct 2019 10:39:54 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Sat, Oct 12, 2019 at 10:07 AM Randy Dunlap <rdunlap@...radead.org> wrote:
> > On 10/11/19 8:54 PM, Dan Robertson wrote:  
> 
> > > +config BMA400_I2C
> > > +     tristate
> > > +     depends on BMA400
> > > +     depends on I2C
> > > +     select REGMAP_I2C
> > > +  
> >
> > The bma400_i2c driver seems to use some OF interfaces.
> > Should it also depend on OF?  
> 
> Please, avoid unnecessary and strict dependencies when it's limiting
> the area of use the driver.
> The driver does not depend to OF. Why to stick with OF?
> 
> The actual change has to be done is to switch from
> 
> > #include <linux/of.h>  
> 
> to
> 
> #include <linux/mod_devicetable.h>
> 

Good point Andy.  There are numerous drivers in IIO that do the same
over enthusiastic including of linux/of.h just to get of_device_id
definition.  Would be good to clean those up to just include this
instead.

This is going to cause very little noise so if there are any new
contributors reading this it would be a nice sensible cleanup to get
started with!

Thanks,

Jonathan