linux-kernel - Re: [PATCH net] rxrpc: Fix possible NULL pointer access in ICMP handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbf115d1-8197-426c-cbe8-bd1f5cff2041@gmail.com>
Date:   Sat, 12 Oct 2019 04:06:08 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        David Howells <dhowells@...hat.com>, netdev@...r.kernel.org
Cc:     linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix possible NULL pointer access in ICMP
 handling



On 10/12/19 3:49 AM, Eric Dumazet wrote:

> 
> Okay, but we also need this.
> 
> diff --git a/net/rxrpc/peer_event.c b/net/rxrpc/peer_event.c
> index c97ebdc043e44525eaecdd54bc447c1895bdca74..38db10e61f7a5cb50f9ee036b5e16ec284e723ac 100644
> --- a/net/rxrpc/peer_event.c
> +++ b/net/rxrpc/peer_event.c
> @@ -145,9 +145,9 @@ static void rxrpc_adjust_mtu(struct rxrpc_peer *peer, struct sock_exterr_skb *se
>   */
>  void rxrpc_error_report(struct sock *sk)
>  {
> +       struct rxrpc_local *local = rcu_dereference_sk_user_data(sk);
>         struct sock_exterr_skb *serr;
>         struct sockaddr_rxrpc srx;
> -       struct rxrpc_local *local = sk->sk_user_data;
>         struct rxrpc_peer *peer;
>         struct sk_buff *skb;
> 

I will psubmit the patch later once David pushes his net tree, since I do not know yet
the sha1 of your patch (to provide a proper Fixes: tag)