linux-kernel - RE: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 12 Oct 2019 01:09:47 +0000
From:   Anson Huang <anson.huang@....com>
To:     Vladimir Oltean <olteanv@...il.com>
CC:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Andy Duan <fugang.duan@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "swboyd@...omium.org" <swboyd@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional()
 to avoid error message

Hi, Vladimir

> On Fri, 11 Oct 2019 at 04:11, Anson Huang <anson.huang@....com> wrote:
> >
> > Hi, Jakub
> >
> > > On Fri, 11 Oct 2019 00:38:50 +0000, Anson Huang wrote:
> > > > > Hm. Looks like the commit you need is commit f1da567f1dc1 ("driver
> core:
> > > > > platform: Add platform_get_irq_byname_optional()") and it's
> > > > > currently in Greg's tree. You have to wait for that commit to
> > > > > make its way into Linus'es main tree and then for Dave Miller to pull
> from Linus.
> > > > >
> > > > > I'd suggest you check if your patches builds on the net tree:
> > > > >
> > > > >   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> > > > >
> > > > > once a week. My guess is it'll probably take two weeks or so for
> > > > > Greg's patches to propagate to Dave.
> > > >
> > > > Thanks for explanation of how these trees work, so could you
> > > > please wait the necessary patch landing on network tree then apply
> > > > this patch series, thanks for help.
> > >
> > > Unfortunately the networking subsystem sees around a 100 patches
> > > submitted each day, it'd be very hard to keep track of patches which
> > > have external dependencies and when to merge them. That's why we
> > > need the submitters to do this work for us and resubmit when the
> > > patch can be applied cleanly.
> >
> > OK, I will resend this patch series once the necessary patch lands on
> > the network tree.
> 
> What has not been mentioned is that you can't create future dependencies
> for patches which have a Fixes: tag.
> 
> git describe --tags 7723f4c5ecdb # driver core: platform: Add an error
> message to platform_get_irq*() v5.3-rc1-13-g7723f4c5ecdb
> 
> git describe --tags f1da567f1dc # driver core: platform: Add
> platform_get_irq_byname_optional()
> v5.4-rc1-46-gf1da567f1dc1
> 
> So you have to consider whether the patch is really fixing anything (it is only
> getting rid of a non-fatal error message).
> And it's not reasonable anyway to say that you're fixing the patch that added
> the error message in the generic framework.
> The fallback logic has always been there in the driver. So you might want to
> drop the Fixes: tag when you resend.

OK, I agree that such kind of patch should NOT add fix tag, but I was confused when
I created this patch, as I saw many similar patches also has fix tag, such as below 2
examples.

I will drop the fix tag when resend the patch series.

commit 71eea7071583b04e9b796ee1d6f7a07334426495
Author: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date:   Thu Oct 10 11:15:20 2019 +0300

    platform/x86: intel_punit_ipc: Avoid error message when retrieving IRQ

    Since the commit

      7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")

    the platform_get_irq() started issuing an error message which is not
    what we want here.

    Switch to platform_get_irq_optional() to have only warning message
    provided by the driver.

    Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

drivers/platform/x86/intel_punit_ipc.c

commit 392fb8df528b97a06e19312772afd38aec542b96
Author: Geert Uytterhoeven <geert+renesas@...der.be>
Date:   Tue Oct 1 20:07:43 2019 +0200

    serial: sh-sci: Use platform_get_irq_optional() for optional interrupts

    As platform_get_irq() now prints an error when the interrupt does not
    exist, scary warnings may be printed for optional interrupts:

        sh-sci e6550000.serial: IRQ index 1 not found
        sh-sci e6550000.serial: IRQ index 2 not found
        sh-sci e6550000.serial: IRQ index 3 not found
        sh-sci e6550000.serial: IRQ index 4 not found
        sh-sci e6550000.serial: IRQ index 5 not found

    Fix this by calling platform_get_irq_optional() instead for all but the
    first interrupts, which are optional.

    Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
    Reviewed-by: Stephen Boyd <swboyd@...omium.org>
    Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
    Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
    Link: https://lore.kernel.org/r/20191001180743.1041-1-geert+renesas@glider.be
    Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

drivers/tty/serial/sh-sci.c

thanks,
Anson