linux-kernel - Re: [PATCH] netdevsim: Fix error handling in nsim_fib_init and nsim_fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191012153156.01d962f1@cakuba.netronome.com>
Date:   Sat, 12 Oct 2019 15:31:56 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH] netdevsim: Fix error handling in nsim_fib_init and
 nsim_fib_exit

On Fri, 11 Oct 2019 17:46:53 +0800, YueHaibing wrote:
> In nsim_fib_init(), if register_fib_notifier failed, nsim_fib_net_ops
> should be unregistered before return.
> 
> In nsim_fib_exit(), unregister_fib_notifier should be called before
> nsim_fib_net_ops be unregistered, otherwise may cause use-after-free:
> 
> BUG: KASAN: use-after-free in nsim_fib_event_nb+0x342/0x570 [netdevsim]
> Read of size 8 at addr ffff8881daaf4388 by task kworker/0:3/3499
> 

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 59c84b9fcf42 ("netdevsim: Restore per-network namespace accounting for fib entries")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>