linux-kernel - Re: [PATCH 0/7] add support for clocksource/clockevent DT selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14df6e5d-19ef-4ebc-fd11-9953bc3fc44e@linaro.org>
Date:   Sun, 13 Oct 2019 20:16:10 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Claudiu.Beznea@...rochip.com, robh+dt@...nel.org,
        mark.rutland@....com, linux@...linux.org.uk, nsekhar@...com,
        bgolaszewski@...libre.com, monstr@...str.eu, john@...ozen.org,
        ralf@...ux-mips.org, paul.burton@...s.com, jhogan@...nel.org,
        lftan@...era.com, tglx@...utronix.de, vgupta@...opsys.com,
        marc.zyngier@....com, patrice.chotard@...com,
        mcoquelin.stm32@...il.com, alexandre.torgue@...com,
        eric@...olt.net, wahrenst@....net, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, linus.walleij@...aro.org,
        shc_work@...l.ru, kgene@...nel.org, krzk@...nel.org,
        ysato@...rs.sourceforge.jp, liviu.dudau@....com,
        sudeep.holla@....com, lorenzo.pieralisi@....com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, baohua@...nel.org,
        Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com,
        Ludovic.Desroches@...rochip.com, baruch@...s.co.il,
        u.kleine-koenig@...gutronix.de, guoren@...nel.org,
        kaloz@...nwrt.org, khalasa@...p.pl, ssantosh@...nel.org,
        vz@...ia.com, slemieux.tyco@...il.com, khilman@...libre.com,
        avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
        venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
        afaerber@...e.de, manivannan.sadhasivam@...aro.org,
        narmstrong@...libre.com, agross@...nel.org, palmer@...ive.com,
        aou@...s.berkeley.edu, heiko@...ech.de, orsonzhai@...il.com,
        baolin.wang@...aro.org, zhang.lyra@...il.com,
        maxime.ripard@...tlin.com, wens@...e.org, thierry.reding@...il.com,
        jonathanh@...dia.com, linux@...sktech.co.nz,
        john.stultz@...aro.org, sboyd@...nel.org, matthias.bgg@...il.com
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        nios2-dev@...ts.rocketboards.org,
        linux-snps-arc@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        uclinux-h8-devel@...ts.sourceforge.jp,
        linux-amlogic@...ts.infradead.org, openbmc@...ts.ozlabs.org,
        linux-oxnas@...ups.io, linux-arm-msm@...r.kernel.org,
        linux-unisoc@...ts.infradead.org, linux-riscv@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 0/7] add support for clocksource/clockevent DT selection


Hi Claudiu,

sorry for the delay, I was OoO again.

On 03/10/2019 12:43, Claudiu.Beznea@...rochip.com wrote:
> 
> 
> On 02.10.2019 16:35, Claudiu Beznea wrote:
>> Hi Daniel,
>>
>> Taking into account that Rob doesn't agree with the solution proposed in
>> this series do you think there is a chance to merge this driver as is?
> 
> Sorry, I was talking here about the driver at [1].
> 
> [1] https://lore.kernel.org/lkml/1552580772-8499-1-git-send-email-claudiu.beznea@microchip.com/

Damn! 7 months old. I'm truly sorry we do not have progress on this. Let
fix this once and for all.

In the driver:

ret = of_property_read_u32(node, "clock-frequency", &freq);

It is unclear how is used this property. It should be the frequency
driving the timer, but can we get from a clk_get_rate() and a fixed divider?


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog