linux-kernel - Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191013191450.GA2792@localhost.localdomain>
Date:   Sun, 13 Oct 2019 19:15:03 +0000
From:   <Narendra.K@...l.com>
To:     <Narendra.K@...l.com>
CC:     <linux-efi@...r.kernel.org>, <ard.biesheuvel@...aro.org>,
        <Mario.Limonciello@...l.com>, <geert@...ux-m68k.org>,
        <mingo@...nel.org>, <tglx@...utronix.de>, <james.morse@....com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] Ask user input only when CONFIG_X86 or
 CONFIG_COMPILE_TEST is set to y

Hi Ard,

On Sun, Oct 13, 2019 at 06:57:05PM +0000, K, Narendra wrote:
> From: Narendra K <Narendra.K@...l.com>
> 
> For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> for input on platforms where the option may not be applicable. This patch
> modifies the kconfig option to ask the user for input only when CONFIG_X86
> or CONFIG_COMPILE_TEST is set to y.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Fix-suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Narendra K <Narendra.K@...l.com>
> ---
I missed mentioning the following details -

This patch is created on kernel version 5.4-rc2

Changes in v1:
- dropped following changes
	'depends on EFI' as it is implied
	'default n' as 'n' is the default if not mentioned
	splitting 'bool' to 'bool + prompt'
- added dependency on X86 || COMPILE_TEST
- added the 'Reported-by:' and 'Fix-suggested-by:' to give credit to 
Geert Uytterhoeven who reported the issue and suggested the fix 


>  drivers/firmware/efi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 178ee8106828..b248870a9806 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -182,6 +182,7 @@ config RESET_ATTACK_MITIGATION
>  
>  config EFI_RCI2_TABLE
>  	bool "EFI Runtime Configuration Interface Table Version 2 Support"
> +	depends on X86 || COMPILE_TEST
>  	help
>  	  Displays the content of the Runtime Configuration Interface
>  	  Table version 2 on Dell EMC PowerEdge systems as a binary
> -- 
> 2.18.1
> 
> -- 
> With regards,
> Narendra K

-- 
With regards,
Narendra K