linux-kernel - Re: [PATCH] writeback: Fix a warning while "make xmldocs"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 12 Oct 2019 23:17:18 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Masanari Iida <standby24x7@...il.com>, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        tj@...nel.org, axboe@...nel.dk
Subject: Re: [PATCH] writeback: Fix a warning while "make xmldocs"

On 10/12/19 9:08 PM, Masanari Iida wrote:
> This patch fix following warning.
> ./fs/fs-writeback.c:918: warning: Excess function parameter
> 'nr_pages' description in 'cgroup_writeback_by_id'
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>
> ---
>  fs/fs-writeback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index e88421d9a48d..8461a6322039 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -905,7 +905,7 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi,
>   * cgroup_writeback_by_id - initiate cgroup writeback from bdi and memcg IDs
>   * @bdi_id: target bdi id
>   * @memcg_id: target memcg css id
> - * @nr_pages: number of pages to write, 0 for best-effort dirty flushing
> + * @nr: number of pages to write, 0 for best-effort dirty flushing
>   * @reason: reason why some writeback work initiated
>   * @done: target wb_completion
>   *
> 

https://lore.kernel.org/linux-fsdevel/756645ac-0ce8-d47e-d30a-04d9e4923a4f@infradead.org/

Andrew has already added this to his patches.

-- 
~Randy