linux-kernel - RE: [EXT] Re: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB41582B7ADE5D8786DE937CA5E9900@VI1PR04MB4158.eurprd04.prod.outlook.com>
Date:   Mon, 14 Oct 2019 07:47:58 +0000
From:   Yinbo Zhu <yinbo.zhu@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     Leo Li <leoyang.li@....com>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Xiaobo Xie <xiaobo.xie@....com>,
        Jiafei Pan <jiafei.pan@....com>, Ran Wang <ran.wang_1@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip
 on layerscape



-----Original Message-----
From: Shawn Guo <shawnguo@...nel.org> 
Sent: 2019年10月14日 14:52
To: Yinbo Zhu <yinbo.zhu@....com>
Cc: Leo Li <leoyang.li@....com>; Rob Herring <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>; Xiaobo Xie <xiaobo.xie@....com>; Jiafei Pan <jiafei.pan@....com>; Ran Wang <ran.wang_1@....com>; linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: [EXT] Re: [PATCH v2] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape

Caution: EXT Email

On Tue, Sep 24, 2019 at 11:29:03AM +0800, Yinbo Zhu wrote:
> layerscape otg function should be supported HNP SRP and ADP protocol 
> accroing to rm doc, but dwc3 code not realize it and use id pin to 
> detect who is host or device(0 is host 1 is device) this patch is to 
> enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@....com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 4 ++++  
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 4 ++++  
> arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 1 +

> this is an arm64 DTS patch, so the patch prefix should be something like 'arm64 dts: fsl: ...'
    
> Shawn 
Hi Shawn guo,

This patch I had updated to v3, please check that v3 version.

Regards,
Yinbo Zhu.
>  3 files changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 9fb9113..076cac6 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -171,3 +171,7 @@
>  &sata {
>       status = "okay";
>  };
> +
> +&usb1 {
> +     dr_mode = "otg";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 6a6514d..0c742be 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -122,6 +122,10 @@
>       };
>  };
>
> +&usb1 {
> +     dr_mode = "otg";
> +};
> +
>  #include "fsl-ls1046-post.dtsi"
>
>  &fman0 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 8e925df..90b1989 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -95,5 +95,6 @@
>  };
>
>  &usb1 {
> +     dr_mode = "otg";
>       status = "okay";
>  };
> --
> 2.9.5
>