linux-kernel - Re: [PATCH] USB: host: ohci-at91: Remove unused variable regs in at91_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bff9bdd9-bc3c-e333-7b4a-df53194de06f@microchip.com>
Date:   Mon, 14 Oct 2019 08:07:03 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <natechancellor@...il.com>, <stern@...land.harvard.edu>,
        <gregkh@...uxfoundation.org>
CC:     <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: host: ohci-at91: Remove unused variable regs in
 at91_stop_hc

On 11/10/2019 at 20:59, Nathan Chancellor wrote:
> drivers/usb/host/ohci-at91.c:118:28: warning: unused variable 'regs'
> [-Wunused-variable]
>          struct ohci_regs __iomem *regs = hcd->regs;
>                                    ^
> 1 warning generated.
> 
> Fixes: 9c4567fa0a44 ("USB: host: ohci-at91: completely shutdown the controller in at91_stop_hc()")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/usb/host/ohci-at91.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index 513e48397743..b635c6a1b1a9 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -115,7 +115,6 @@ static void at91_start_hc(struct platform_device *pdev)
>   static void at91_stop_hc(struct platform_device *pdev)
>   {
>   	struct usb_hcd *hcd = platform_get_drvdata(pdev);
> -	struct ohci_regs __iomem *regs = hcd->regs;
>   	struct ohci_at91_priv *ohci_at91 = hcd_to_ohci_at91_priv(hcd);
>   
>   	dev_dbg(&pdev->dev, "stop\n");
> 


-- 
Nicolas Ferre