[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DB7PR04MB44908DE0F57E985ED40C401A8F900@DB7PR04MB4490.eurprd04.prod.outlook.com>
Date: Mon, 14 Oct 2019 03:21:14 +0000
From: Biwen Li <biwen.li@....com>
To: Rob Herring <robh@...nel.org>
CC: "peda@...ntia.se" <peda@...ntia.se>, Leo Li <leoyang.li@....com>,
"mark.rutland@....com" <mark.rutland@....com>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [EXT] Re: [v2,2/2] dt-bindings: i2c-mux-pca954x: Add optional
property i2c-mux-never-disable
>
> On Mon, Sep 30, 2019 at 11:25:03AM +0800, Biwen Li wrote:
> > The patch adds an optional property i2c-mux-never-disable
> >
> > Signed-off-by: Biwen Li <biwen.li@....com>
> > ---
> > Change in v2:
> > - update documentation
> >
> > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > index 30ac6a60f041..71b73d0fdb62 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > @@ -34,6 +34,7 @@ Optional Properties:
> > - first cell is the pin number
> > - second cell is used to specify flags.
> > See also
> > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> > + - i2c-mux-never-disable: always forces mux to be enabled.
>
> Either needs to have a vendor prefix or be documented as a common
> property.
>
> IIRC, we already have a property for mux default state which seems like that
> would cover this unless you need to leave it in different states.
Okay, you are right, thank you so much. I will try it in v3.
>
> Rob
Powered by blists - more mailing lists