linux-kernel - Re: [PATCH v4] rtc: wilco-ec: Handle reading invalid times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191014155021.GR3125@piout.net>
Date:   Mon, 14 Oct 2019 17:50:21 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Nick Crews <ncrews@...omium.org>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>,
        enric.balletbo@...labora.com, bleung@...omium.org,
        dlaurie@...omium.org, djkurtz@...omium.org, dtor@...gle.com,
        campello@...omium.org
Subject: Re: [PATCH v4] rtc: wilco-ec: Handle reading invalid times

On 04/10/2019 08:26:08-0600, Nick Crews wrote:
> If the RTC HW returns an invalid time, the rtc_year_days()
> call would crash. This patch adds error logging in this
> situation, and removes the tm_yday and tm_wday calculations.
> These fields should not be relied upon by userspace
> according to man rtc, and thus we don't need to calculate
> them.
> 
> Signed-off-by: Nick Crews <ncrews@...omium.org>
> ---
>  drivers/rtc/rtc-wilco-ec.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com