linux-kernel - Re: [PATCH] perf stat: Support --all-kernel/--all-user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191014162339.GN19627@kernel.org>
Date:   Mon, 14 Oct 2019 13:23:39 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jin Yao <yao.jin@...ux.intel.com>, jolsa@...nel.org,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH] perf stat: Support --all-kernel/--all-user

Em Mon, Oct 14, 2019 at 04:42:08PM +0200, Jiri Olsa escreveu:
> On Fri, Oct 11, 2019 at 01:05:45PM +0800, Jin Yao wrote:
> > perf record has supported --all-kernel / --all-user to configure all
> > used events to run in kernel space or run in user space. But perf
> > stat doesn't support these options.
> > 
> > It would be useful to support these options in perf-stat too to keep
> > the same semantics.
> > 
> > Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

What happens if one asks for both? From the patch only the --all-kernel
will stick, right? Is that the behaviour for 'perf record'? Lemme see,
as I recall having this discussion at that time...

Yeah, same thing, and looking at that I wonder why we dong use
perf_evsel__config() in 'perf stat'...

Ok, I'm going to apply it.
 
> thanks,
> jirka
> 
> > ---
> >  tools/perf/Documentation/perf-stat.txt |  6 ++++++
> >  tools/perf/builtin-stat.c              |  6 ++++++
> >  tools/perf/util/stat.c                 | 10 ++++++++++
> >  tools/perf/util/stat.h                 |  2 ++
> >  4 files changed, 24 insertions(+)
> > 
> > diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
> > index 930c51c01201..a9af4e440e80 100644
> > --- a/tools/perf/Documentation/perf-stat.txt
> > +++ b/tools/perf/Documentation/perf-stat.txt
> > @@ -323,6 +323,12 @@ The output is SMI cycles%, equals to (aperf - unhalted core cycles) / aperf
> >  
> >  Users who wants to get the actual value can apply --no-metric-only.
> >  
> > +--all-kernel::
> > +Configure all used events to run in kernel space.
> > +
> > +--all-user::
> > +Configure all used events to run in user space.
> > +
> >  EXAMPLES
> >  --------
> >  
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index 468fc49420ce..c88d4e118409 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -803,6 +803,12 @@ static struct option stat_options[] = {
> >  	OPT_CALLBACK('M', "metrics", &evsel_list, "metric/metric group list",
> >  		     "monitor specified metrics or metric groups (separated by ,)",
> >  		     parse_metric_groups),
> > +	OPT_BOOLEAN_FLAG(0, "all-kernel", &stat_config.all_kernel,
> > +			 "Configure all used events to run in kernel space.",
> > +			 PARSE_OPT_EXCLUSIVE),
> > +	OPT_BOOLEAN_FLAG(0, "all-user", &stat_config.all_user,
> > +			 "Configure all used events to run in user space.",
> > +			 PARSE_OPT_EXCLUSIVE),
> >  	OPT_END()
> >  };
> >  
> > diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
> > index ebdd130557fb..6822e4ffe224 100644
> > --- a/tools/perf/util/stat.c
> > +++ b/tools/perf/util/stat.c
> > @@ -490,6 +490,16 @@ int create_perf_stat_counter(struct evsel *evsel,
> >  	if (config->identifier)
> >  		attr->sample_type = PERF_SAMPLE_IDENTIFIER;
> >  
> > +	if (config->all_user) {
> > +		attr->exclude_kernel = 1;
> > +		attr->exclude_user   = 0;
> > +	}
> > +
> > +	if (config->all_kernel) {
> > +		attr->exclude_kernel = 0;
> > +		attr->exclude_user   = 1;
> > +	}
> > +
> >  	/*
> >  	 * Disabling all counters initially, they will be enabled
> >  	 * either manually by us or by kernel via enable_on_exec
> > diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
> > index edbeb2f63e8d..081c4a5113c6 100644
> > --- a/tools/perf/util/stat.h
> > +++ b/tools/perf/util/stat.h
> > @@ -106,6 +106,8 @@ struct perf_stat_config {
> >  	bool			 big_num;
> >  	bool			 no_merge;
> >  	bool			 walltime_run_table;
> > +	bool			 all_kernel;
> > +	bool			 all_user;
> >  	FILE			*output;
> >  	unsigned int		 interval;
> >  	unsigned int		 timeout;
> > -- 
> > 2.17.1
> > 

-- 

- Arnaldo