linux-kernel - Re: [PATCH] arm64: cpufeature: Don't expose ZFR0 to userspace when SVE is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <223c22d0-cfe3-4aed-6a8f-b80e44cb6548@arm.com>
Date:   Mon, 14 Oct 2019 17:57:46 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Will Deacon <will@...nel.org>, Julien Grall <julien.grall@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        catalin.marinas@....com, Dave.Martin@....com
Subject: Re: [PATCH] arm64: cpufeature: Don't expose ZFR0 to userspace when
 SVE is not enabled



On 14/10/2019 17:43, Will Deacon wrote:
> On Mon, Oct 14, 2019 at 11:21:13AM +0100, Julien Grall wrote:
>> The kernel may not support SVE if CONFIG_ARM64_SVE is not set and
>> will hide the feature from the from userspace.
> 
> I don't understand this sentence.
> 
>> Unfortunately, the fields of ID_AA64ZFR0_EL1 are still exposed and could
>> lead to undefined behavior in userspace.
> 
> Undefined in what way? Generally, we can't stop exposing things that
> we've exposed previously in case somebody has started relying on them, so
> this needs better justification.

We still expose them with this patch, but zero them out, if the SVE is not
supported. When SVE is enabled, we expose them as usual.

Cheers
Suzuki