lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Oct 2019 20:55:40 -0700 From: Yizhuo Zhai <yzhai003@....edu> To: Sebastian Reichel <sre@...nel.org> Cc: Beomho Seo <beomho.seo@...sung.com>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, Zhiyun Qian <zhiyunq@...ucr.edu>, Chengyu Song <csong@...ucr.edu> Subject: Re: Potential uninitialized variables in power: supply: rt5033_battery: Hi Sebastian: Thanks for your explanation and I will send the patch accordingly. On Sun, Oct 13, 2019 at 8:12 PM Sebastian Reichel <sre@...nel.org> wrote: > > Hi, > > On Thu, Oct 03, 2019 at 09:21:44PM -0700, Yizhuo Zhai wrote: > > drivers/power/supply/rt5033_battery.c: > > > > In function rt5033_battery_get_present(), variable "val" could be > > uninitialized if regmap_read() returns -EINVAL. However, "val" is > > used to decide the return value, which is potentially unsafe. > > > > Also, we cannot simply return -EINVAL in rt5033_battery_get_present() > > because it's not an acceptable return value. > > > > Thanks for your time to check this case. > > Should be fine to just return false when regmap_read() fails. > Will you prepare a patch for that? > > Thanks, > > -- Sebastian -- Kind Regards, Yizhuo Zhai Computer Science, Graduate Student University of California, Riverside
Powered by blists - more mailing lists